Using FieldSet.from_sgrid_conventions() in tutorials #2437
Merged
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reint-fischer
left a comment
reint-fischer
left a comment
There was a problem hiding this comment.
Very nice to see this become easier! Just a few minor comments on impacts for the rendered notebooks.
Implementing the review comments by @reint-fischer
As suggested in the second "note" at https://sgrid.github.io/sgrid/#3d-grid
VeckoTheGecko
approved these changes
Jan 12, 2026
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good , though now there are a bunch of merge conflicts to resolve
Member
Author
|
Yep, I'll fix them before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a
FieldSet.from_sgrid_conventions()(thanks to #2432), we can use this in the tutorials to simplify the creation of FieldSets. This requires though thatsimple_UV_datasetreturns an SGRID-compliant DataSet, which is also implemented in this PR. And that required the tests to be updated